rust-bitcoin / rust-bitcoin/rust-miniscript

Bug: `thresh(k, pubkeys[21])` policy does not compile for `k < 3`

Open
#114 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug wontfix
Dominant language
Rust
Stars
426
Forks
200
Avg merge
7d 17h
Merged PRs (30d)
8

Description

<sanket1729> Yup, that is indeed a bug. The issue is for k = 1 to 3, we pick sub-compilations for children optimally. All pk() are mapped to pkh() with a likely wrapper and that exceeds the max-opcount for 200 
20:01 <sanket1729> The correct compiler logic would pick optimal compilation for children keeping tract of possible op-counts. 
20:02 <sanket1729> But that would lead to even slower compiler with high space requirements. 
20:03 <sanket1729> For k = 4, the probabilities for leaf are high, so their optimal compilations are mapped correctly under the MAX_OP_COUNT
20:03 <sanket1729> sipa: Do you have any inputs?
20:04 <jeremyrubin> "taproot fixes this"
20:06 <sipa> lol
20:06 <sipa> yes
20:06 <sanket1729> Maybe, if the optimal greedy compiler fails. We should build another version that minimizes the op-counts but still constructs some miniscript. 

Should Taproot or us fix this ?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the thresh(k, pubkeys[21]) case for k < 3 and trace the compiler's handling of pk(), pkh(), and MAX_OP_COUNT. Review the discussion of optimal child compilations and Taproot, then determine whether rust-miniscript or Taproot owns the fix. Done means the responsibility is resolved and the affected policy compiles within the op-count limit.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
compilers
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.