rust-bitcoin / rust-bitcoin/rust-bitcoin

CI misses lint warnings in rustdocs

Open
#3,529 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
2.7k
Forks
1k
Avg merge
4d 39m
Merged PRs (30d)
86

Description

Remove the #[allow(deprecated)] from the rustdocs of sha256t_hash_newtype and run just lint - gives a warning. But CI passed on https://github.com/rust-bitcoin/rust-bitcoin/pull/3528 without it.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the rustdocs for sha256t_hash_newtype and reproduce the issue by removing #[allow(deprecated)]. Run just lint, then compare the result with the CI outcome reported for pull request 3528. Done means CI reports the same lint warning instead of passing silently.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
ci-cd
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.