rust-bitcoin / rust-bitcoin/rust-bitcoin
Make `Psbt::sighash_ecdsa` private
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 2.7k
- Forks
- 1k
- Avg merge
- 4d 1h
- Merged PRs (30d)
- 88
Description
The method takes &mut SighashCache which doesn't enforce that the transaction is equal to unsigned_tx which looks broken. Judging from other methods around it should've been private.
Note: I have some idea how to avoid cloning the transaction during signing but this method being public significantly restricts the design.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate Psbt::sighash_ecdsa and read the neighboring methods to understand the intended visibility and signing API. Trace its callers and verify that making this entry point private addresses the exposed SighashCache and unsigned_tx mismatch concern without breaking the supported signing flow.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- cryptography
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100