rust-bitcoin / rust-bitcoin/rust-bech32

Checksum length

Open
#156 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

1.0
Dominant language
Rust
Stars
100
Forks
74
Avg merge
2d 6h
Merged PRs (30d)
9

Description

we should change the checksum length check so that we enforce it only on the data part, not the HRP or separator. (It appears that for segwit, the BIP says the 90 limit applies to the whole string.)

ref: https://github.com/rust-bitcoin/rust-bech32/pull/142#issuecomment-1781113334

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no files or tests; start by reviewing the checksum-length validation and the referenced pull request discussion. Confirm the intended behavior for the data portion versus the full Bech32 string, including the stated Segwit exception, and add coverage showing the accepted and rejected lengths.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
cryptography
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.