runtimeverification / runtimeverification/kontrol
Support remaining assert methods
Open
@jinxinglim is already working on this.
Since May 27, 2024.
enhancement
good first issue
- Dominant language
- Python
- Stars
- 122
- Forks
- 16
- PR merge metrics
- No merged PRs in 30d
Description
After https://github.com/runtimeverification/kontrol/pull/558, here is a list with the remaining assertions that should be implemented:
- dynamic types string bytes uint256[] int256[] bool[] bytes32[] address[] for assertEq and assertNotEq.
- assertApproxEqAbs and assertApproxEqRel: take an additional maxDelta argument.
- assert*Decimals : take an additional decimals value used to format the values in error messages.
Related links:
Progress
-
assertApproxEqAbs- https://github.com/runtimeverification/kontrol/pull/584 -
assertApproxEqRel- https://github.com/runtimeverification/kontrol/pull/593 -
assert*Decimals- To skip for the time being as they are basically the same as the 2 above, just that the log error displayed will be in decimals -
assertEqfor dynamic types:-
string -
bytes -
uint256[],int256[],bool[],bytes32[]andaddress[]- https://github.com/runtimeverification/kontrol/pull/605
-
-
assertNotEqfor dynamic types:-
string -
bytes -
uint256[],int256[],bool[],bytes32[]andaddress[]
-
Above tasks are completed modulo the following two issues:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.