runtimeverification / runtimeverification/kontrol
Limitations on the `mockCall` cheatcode implementation
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- Python
- Stars
- 122
- Forks
- 16
- PR merge metrics
- No merged PRs in 30d
Description
The current implementation of the mockCall cheatcode has some limitations:
- It does not work if there are multiple mock calls with common prefixes for the same address - see test
MockCallTestFoundry.testMockCallMultiplePartialMatch:
https://github.com/runtimeverification/kontrol/blob/36a6b49527acc906031aea6e6a791b9ecaa4b80e/src/tests/integration/test-data/foundry/test/MockCallTest.t.sol#L111-L121 - The mockCall with the
valueargument it's not currently implemented
Besides, there are other cheatcodes related with mock calls that should be relatively easy to implement:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with MockCallTest.t.sol, especially testMockCallMultiplePartialMatch at lines 111-121, and compare the documented mockCall, mockCallRevert, and clearMockedCalls behavior. Done means resolving common-prefix calls and supporting the value argument, mockCallRevert, and clearMockedCalls, with tests covering each behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python, solidity
- Domain
- testing, tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100