Optimize Foundry test suite

The Foundry test suite we use for CI proofs must be better organized. With duplicated test contracts (such as PlainPrankTest.t.sol and PrankTest.t.sol), contracts that do not use the setUp functionality repeatedly deploy auxiliary contracts in the tests. In addition, a lot of tests are skipped to keep the CI time low.

A few optimizations:

• Get a smaller test-suite codebase, resulting in lower kompile time:

  • Merge duplicated contracts
  • Remove/merge tests with duplicated logic

• Improve performance of the tests:

  • Use the setUp functionality instead of deploying auxiliary contracts in the test.
  • replace assertEq and assertGt assertion calls with assert. Since assertEq is a function from the forge test library, this will reduce the number of kcfg nodes generated by removing calls to the forge test contract. We can add individual unit tests to check that assertEq and assert act similarly.
  • use notBuiltinAddress() in unit tests that use symbolic addresses to avoid unnecesary branchings.

By implementing these we could (1) reduce CI time and/or (2) run more tests that are currently skipped in the same amount of time.

Start by inspecting the Foundry test suite, especially PlainPrankTest.t.sol and PrankTest.t.sol, then identify duplicated test logic and auxiliary-contract deployments. Review the skipped tests and uses of setUp, assertEq, assertGt, and notBuiltinAddress. Done means a smaller, faster suite with fewer skipped tests while retaining equivalent assertion coverage.