runtimeverification / runtimeverification/kontrol

`kontrol simplify-node --lemmas` broken

Open
#1,133 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
122
Forks
16
PR merge metrics
No merged PRs in 30d

Description

kontrol simplify-node simplifies a given node in a proof and returns the output. It also has a flag --lemmas <lemmas.k file>:<MODULE_NAME> with which a lemmas file can be passed that is kompiled and used as well.

However, according to my observation this --lemmas flag is currently broken. It seems to me that the lemmas file is kompiled and sent to the haskell-backend, but not referenced in simplification requests and therefore unused. As a consequence, this feature cannot be used to test simplification lemmas.

Additionally, kontrol simplify-node --lemmas <lemmas.k file>:<MODULE_NAME> crashes when a simplification rule uses preserves-definedness.

This can be reproduced with this kontrol repository: https://github.com/juliankuners/test-simplify-node

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the problem with kontrol simplify-node --lemmas <lemmas.k file>:<MODULE_NAME> using the linked test-simplify-node repository. Inspect how the lemmas file is compiled, passed to the Haskell backend, and referenced by simplification requests, then investigate the crash with preserves-definedness. Done means both lemma use and that rule work without crashing.

Written by the indexing model from the issue text.

Assessment

Tech stack
haskell, python
Domain
backend, cli
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.