Wrong type annotations in pyk

Open
#4,660 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
tooling

Research direction

Start in pyk.kcfg.kcfg.py at create_ndbranch and compare its annotations with the nested KCFG.NDBranch type versus the separate NDBranch class. Review the other annotations in that file for the same naming problem, then use the language server to confirm the reported errors are resolved.

Written by the indexing model from the issue text.

Description

In pyk.kcfg.kcfg.py, the create_ndbranch function says that the key of KCFG._ndbranches should be of type KCFG.NDBranch. However, it is mistakenly annotated as NDBranch, which actually points to class NDBranch(KCFGExtendResult). There are lots of wrong annotations like this in that file and as a result I get lots of error from lsp.

Dominant language
Python
Stars
591
Forks
163
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from runtimeverification/k

All issues in runtimeverification/k

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.