Overly verbose `INFO` log on subsumption check

Open
#4,202 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
55/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
tooling

Research direction

Start by tracing the INFO messages from pyk.proof.reachability during the subsumption check and pyk.cterm.symbolic during get-model requests, using kontrol prove --verbose to reproduce them. Done means the implication and model terms no longer appear at INFO level, while the high-level step and request messages remain visible and the relevant logging behavior is covered by existing tests if available.

Written by the indexing model from the issue text.

Description

enhancement pyk

When the prover (e.g. kontrol prove) is ran with --verbose, the log level INFO is forwarded to stderr, which is very useful to see the high-level steps the prover makes.

However, at the subsumption check step, i.e. when preparing an implies request to the server, the prover outputs the whole implication term Kast at INFO level, which clutters the log:

...
INFO 2024-03-19 08:15:36,734 pyk.proof.reachability - Checking subsumption into target state 
test%ArithmeticCallTest.test_double_add(uint256,uint256):0: (19, CTerm(config=KApply(label=KLabel(name='<generatedTop>', 
params=()), args=(KApply(label=KLabel(name='<foundry>', params=()), args=(KApply(label=KLabel(name='<kevm>', params=()), 
args=(KApply(label=KLabel(name='<k>', params=()), args=(KSequence(items=(KApply(label=KLabel(name='#halt_EVM_KItem', 
params=( ....
...

Same applies to the get-model requests:

INFO 2024-03-19 08:16:09,730 pyk.kore.rpc - Received response from localhost:44199: 45 - implies
INFO 2024-03-19 08:16:09,852 pyk.cterm.symbolic - Getting model: CTerm(config=KApply(label=KLabel(name='<generatedTop>',
 params=()), args=(KApply(label=K ...

Suggestion: output the implication term and the get model term at DEBUG level instead.

Dominant language
Python
Stars
591
Forks
163
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from runtimeverification/k

All issues in runtimeverification/k

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.