Move sentence classifiers from `KDefinition` to `Sentence` subclasses

Open
#4,200 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
42/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
compilers

Research direction

Read the discussion in PR 991 and inspect the example in src/pyk/kast/outer.py around line 863. Trace the sentence classifiers currently associated with KDefinition and compare the Sentence subclasses, including the requested KProduction.is_function behavior. Done means the classifiers are owned by the appropriate Sentence subclasses without changing their intended results.

Written by the indexing model from the issue text.

Description

pyk

Original discussion: https://github.com/runtimeverification/pyk/pull/991#discussion_r1528969189

Example: https://github.com/runtimeverification/pyk/blob/d0f2f62f0c2b4e970cc9e146eb7da3b649dddee2/src/pyk/kast/outer.py#L863

This should become KProduction.is_function.

Dominant language
Python
Stars
591
Forks
163
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from runtimeverification/k

All issues in runtimeverification/k

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.