Fix regression in KORE symbol attributes between K and `pyk`

Open
#4,184 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
compilers, testing

Research direction

Start with test_module_to_kore in src/tests/integration/test_konvert.py, especially the excluded KORE-attribute list around line 41. Examine each entry against the K and pyk outputs, then determine whether it belongs at KAST simplification, after simplification, after KAST-to-KORE conversion, or requires generation. Done means the comparison no longer relies on unjustified exclusions and the integration test passes.

Written by the indexing model from the issue text.

Description

pyk

Currently, test_module_to_kore has a list of KORE attributes that are excluded from the comparison of the generated KORE:

https://github.com/runtimeverification/pyk/blob/9eae79b4e271309db75cef082a4f449eb6c0f685/src/tests/integration/test_konvert.py#L41

Each attribute in the list is either:

  • Generated by pyk, not generated by K runtimeverification/k#3983
  • Generated by K, not generated by pyk

Entries should be considered one-by-one, and the appropriate action taken:

  • Discard the attribute at the start of KAST simplification
  • Discard the attribute at the end of KAST simplification
  • Discard the attribute after KAST-to-KORE conversion (less likely)
  • Implement attribute generation
Dominant language
Python
Stars
591
Forks
163
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from runtimeverification/k

All issues in runtimeverification/k

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.