Revisit attributes `assoc`, `comm`, `idem` and `unit`

Open
#3,977 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
25/100
Issue type
Refactor
Clarity
Needs clarification
Activity status
Stale
Tech stack
java
Domain
compilers

Research direction

Start with ModuleToKORE.java at the referenced line and read the linked discussion in pyk pull request 861. Determine whether assoc, comm, idem, and unit should still affect injective or constructor classification; done means reaching a documented decision and updating the relevant behavior or rationale.

Written by the indexing model from the issue text.

Description

attributes question

Related: https://github.com/runtimeverification/pyk/pull/861#discussion_r1482992307

Currently, when establishing whether a symbol is an injective / constructor symbol, ModuleToKORE considers attributes assoc, comm, idem and unit.

Source: https://github.com/runtimeverification/k/blob/1e4aa2be6b49ca766e01d78eae0e418a749bb12b/kernel/src/main/java/org/kframework/backend/kore/ModuleToKORE.java#L1666

Is this still consistent with how these attributes are intended to be used?

Dominant language
Python
Stars
591
Forks
163
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from runtimeverification/k

All issues in runtimeverification/k

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.