runtimeverification / runtimeverification/haskell-backend
Treat all terms of sort `Bool` as `Predicate` in `"get-model"`
Nobody has claimed this yet.
- Dominant language
- Haskell
- Stars
- 224
- Forks
- 43
- PR merge metrics
- No merged PRs in 30d
Description
Currently, if we send a "get-model" request to kore-rpc-booster/booster-dev with a KoreJson term with e.g. ==Int:
{"format":"KORE","version":1,"term":{"tag":"App","name":"Lbl'UndsEqlsEqls'Int'Unds'","sorts":[],"args":[{"tag":"DV","sort":{"tag":"SortApp","name":"SortInt","args":[]},"value":"1"},{"tag":"DV","sort":{"tag":"SortApp","name":"SortInt","args":[]},"value":"1"}]}}
we will get the following warning:
[Warn#booster] get-model ignores supplied terms and only checks predicates
and an Unknwon response.
This happens because we only recognize a very limited class of terms as predicates.
In get-model requests, we should recognize all terns of sort Bool as predicates.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the get-model request handling in kore-rpc-booster or booster-dev and trace how KoreJson terms are classified as predicates. Confirm the behavior with a Bool-sorted term such as ==Int; done means Bool-sorted terms are accepted as predicates without the warning and no longer produce an Unknown response.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- haskell
- Domain
- api, backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100