runtimeverification / runtimeverification/evm-semantics

Reproducing proofs from LUKSO engagement

Open
#1,681 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
KCL
Stars
591
Forks
156
Avg merge
2h 19m
Merged PRs (30d)
1

Description

The following branch of the repo used for the LUKSO audit has been set up to reproduce the proofs from the engagement (see the README for instructions): https://github.com/runtimeverification/_audit_Lukso_07292426-ab46-4492-adcd-4bd34d864353/tree/reproduce-merge

The proofs had to be updated for compatibility with recent updates to KEVM (for example, calling kevm.infiniteGas()). However, some of the proofs that passed during the engagement are now getting stuck. I have confirmed that this is happening to at least the following proofs (when using the version of KEVM corresponding to commit 38f3bf6ee75bbcf67363313ee01af3957a98b3d1):

  • FallbackTest.testCallExtension
  • ERC725XTest.testCannotExecuteIfNotOwner
  • ERC725YTest.testSetData1NotOwner

Fixing this will be necessary to re-run the proofs after upstreaming the lemmas in #1606.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the README on the reproduce-merge branch of the linked audit repository, using KEVM at commit 38f3bf6ee75bbcf67363313ee01af3957a98b3d1. Reproduce the stuck proofs in FallbackTest.testCallExtension, ERC725XTest.testCannotExecuteIfNotOwner, and ERC725YTest.testSetData1NotOwner. Done means these proofs run successfully again so the lemmas from #1606 can be upstreamed.

Written by the indexing model from the issue text.

Assessment

Domain
blockchain
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.