rubyforgood / rubyforgood/human-essentials

Behaviour re name when adding existing user to partner

Open
#5,612 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

stale
Dominant language
Ruby
Stars
593
Forks
593
Avg merge
4d 22h
Merged PRs (30d)
41

Description

When, as a bank, we add an existing user to a partner, the name field has no effect -- even if the existing user has no name.

This is, to be sure, an edge case -- was just a bit of a surprise when testing -- might want to discuss if there should be any feedback in this case.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the bank workflow described in issue #5612: add an existing user to a partner while entering a name. Trace the existing-user-to-partner path and confirm whether the name is intentionally ignored. The issue needs an expected outcome agreed before implementation; done should include the chosen behavior and coverage for this edge case.

Written by the indexing model from the issue text.

Assessment

Tech stack
rails, ruby
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Needs clarification
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.