rubyforgood / rubyforgood/human-essentials

Add a confirmation step on kit entry

Open
#5,566 8 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Difficulty—Intermediate stale
Dominant language
Ruby
Stars
593
Forks
593
Avg merge
4d 22h
Merged PRs (30d)
41

Description

Summary

Add a confirmation step on kit entry

Why?

The inability to edit the contents on the kit is by design. Adding a confirmation step on creation could forestall some kits created in error.

Details

How to create a kit

Log in a org_admin1@example.com
click Inventory, then Kits
Click "+New Kit"
provide a name for the kit
select some items and quantities for the kit.
Click save

What we want

At save
Add a confirmation step (similar to the step on distribution) to the kit creation. Example modal from distribution:

Image

Kit Creation Confirmation

You are about to create a kit named [name of the kit] with value [value for kit]

Item Name Quantity
[List of item names and quantities]

"Please confirm that this is the correct composition of the kit. Note: You will not be able to edit the items contained in the kit ."

and buttons "No, I need to make changes", and "Yes, it's correct"


(Perhaps have the "not" in the confirmation in red, if that is easily done)

If the user clicks "Yes", the save process will continue as before. If they click "No", we return them to the form they were filling in (with all their values still there)

Criteria for completion

  • behaviour as indicated
  • tests to support that behaviour
  • update kit portion of user guide to reflect changes

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the Kits New Kit form and the existing distribution confirmation flow described in the issue. Check how kit values, item names, quantities, and form state are handled at save, then review the kit portion of the user guide. Done means the confirmation supports both choices, preserves entered values when editing, has tests, and documents the new behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
rails, ruby
Domain
backend, documentation, frontend, testing
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.