rubyforgood / rubyforgood/human-essentials
[BUG]: Submit buttons remain in 'Saving' State when Duplicate Modal is Closed
Open
@LizPrescott is already working on this.
Since Aug 28, 2026.
🐞 Bug
- Dominant language
- Ruby
- Stars
- 593
- Forks
- 593
- Avg merge
- 4d 22h
- Merged PRs (30d)
- 41
Description
Is there an existing issue for this?
- I have searched the existing issues
Current Behavior
When creating or editing an audit, if duplicate items are detected and the modal is shown, dismissing the modal without merging (by clicking "Make Changes" or the X button) leaves the "Save Progress" and "Confirm Audit" buttons stuck in a disabled "Saving" state.
Expected Behavior
The buttons should not say "Saving", but rather "Save Progress" and "Confirm Audit"
Steps To Reproduce
Staging
- Navigate to the Inventory Audit page
- Add the same item multiple times with different quantities
- Click "Save Progress" or "Confirm Audit"
- Duplicate items modal appears
- Click "Make Changes" or the X button to close the modal
- Observe that the submit buttons remain disabled and show "Saving"
Criteria for Completion
No response
Anything else?
No response
Code of Conduct
- I've read the Code of Conduct and understand my responsibilities as a member of the Ruby for Good community
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.