rubyforgood / rubyforgood/human-essentials
Apply New Modal for Duplicate Item Entries to Distributions/Donations/Purchases etc.
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 593
- Forks
- 593
- Avg merge
- 4d 22h
- Merged PRs (30d)
- 41
Description
Is there an existing request for this feature?
- I have searched the existing issues
Is there a pain point in the app driving this feature request?
We have implemented a new modal to appear upon Save Progress/Confirm Audit when a user enters a duplicate item in the Inventory Audit. See PR. We would like to apply this logic in all the places in the app that also contain the logic of entering potentially duplicate items.
Desired Behavior
When a user has the ability to enter items in the app (through barcode or manual entry), a modal should appear upon Save if the user has entered duplicate items.
We should see if we can turn the modal used in https://github.com/rubyforgood/human-essentials/pull/5462 to a component for reuse.
Criteria for Completion
- We should be able to merge duplicate items using the 'new' modal.
Anything else?
- We have merged https://github.com/rubyforgood/human-essentials/pull/5538 for kits. We should implement this in the remainder of places where we can have duplicate items
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review PR 5462 to understand the existing duplicate-item modal, then compare the kits implementation in merged PR 5538. Trace the remaining distribution, donation, purchase, and other item-entry flows that accept barcode or manual entries. Done means the reusable modal supports merging duplicates wherever applicable and the completion criterion is satisfied.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ruby
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100