rubyforgood / rubyforgood/human-essentials

Partner profile mandatoriness at submission

Open
#5,327 11 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Difficulty—Advanced stale
Dominant language
Ruby
Stars
593
Forks
593
Avg merge
4d 22h
Merged PRs (30d)
41

Description

Summary

Switch to having mandatory checks on partner profile only at "submit for approval" and later stages. Add several fields to be mandatory at that stage

Why

Because the partner profile is so long, we don't want to enforce this mandatoriness while the partner is trying to fill it out.

Details

Part 1

There is currently one enforced mandatory condition on the partner profile

  • if the social media section is being used, the partner has to fill in some social media or choose "no social media"

This should, instead, only be enforced if the status is "submitted for approval" or "approved"
If the organization has "invite and aprove" true, this is not mandatory.

Part 2

Add the following fields to be mandatory at "submitted for approval" or "approved".
If the organization uses "invite and approve", these fields are not mandatory
"Agency Name" : agency_name,
"Agency Type" : agency_type,
"Address (Line 1)" : address1,
"City": city,
"State": state,
"Zip Code": zip_code,

In the Agency Stability section:
"Program Name": program_name
"Program Description": program_description

Criteria for completion

  • behaviour as described
  • tests to confirm behaviour
  • update the user guide sections on partner profile to reflect the changes.

Origin

Partnerbase working group identified that the following fields should be mandatory in 2022.
"Agency Name" : agency_name,
"Agency Type" : agency_type,
"Address (Line 1)" : address1,
"City": city,
"State": state,
"Zip Code": zip_code,

In the Agency Stability section:
"Program Name": program_name
"Program Description": program_description

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are named. Start by locating the partner profile validation and submission-status entry points, then find the related user guide sections and existing tests. Done means the listed fields and social-media condition are enforced only at the specified stages, the invite-and-approve exception works, tests cover the behavior, and the guide is updated.

Written by the indexing model from the issue text.

Assessment

Tech stack
rails, ruby
Domain
backend, documentation
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.