rubyforgood / rubyforgood/human-essentials

Fix far in the future issued_ats (core team only)

Open
#5,271 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

core team
Dominant language
Ruby
Stars
593
Forks
593
Avg merge
4d 22h
Merged PRs (30d)
41

Description

Summary

From a while ago, there are a number of issued_ats that are in the far future. Need a migration to fix them

why?

They cause incorrect reports, info for partners

Details

We went over the distribution ones in our sunday meeting -- the correct dates for the future dates for distributions are all obvious. We just need to do a migration to make the adjustment.
Check also donations and purchases.

Criteria for completion

  • migration that fixes the itemizables with dates more than 1 year in the future. This is on a piecemeal basis.

Question for devs

Do we need to communicate about these? It's certainly possible that someone has reentered them after not being able to find them.

Further note

We should communicate with the affected users when we fix this. With a mind to inventory levels, etc. So this might be different for different users (depending on the date)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the itemizable records and issued_at fields for distributions, donations, and purchases, then inspect the affected future-dated data. Confirm how the correct dates are determined before designing the migration. Done means records more than one year in the future are corrected piecemeal and the affected-user communication requirement is resolved.

Written by the indexing model from the issue text.

Assessment

Tech stack
rails, ruby
Domain
backend, databases
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.