rubyforgood / rubyforgood/human-essentials

Partner Visibility of items and child requests

Open
#5,224 11 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Difficulty—Intermediate stale
Dominant language
Ruby
Stars
593
Forks
593
Avg merge
4d 22h
Merged PRs (30d)
41

Description

Summary

If the bank takes an action that will remove items from the partner's view, and there are child requests using those items, warn the bank (but do not prevent the action)

Why

Reminding banks of this prompts them to reach out to their partners (put up an announcement) --> less surprise.

Details

If the bank is taking any of these actions, check if items being removed from the partners' use are used in their child requests. If they are, give a confirmation dialog "Note: Items ([list of items]) are currently used by the partners in child requests. Proceed?"

  • item not visible
  • partner groups changing the items that are allowed
  • deactivation

Criteria for completion

  • changes as described above
  • automated tests supporting the changes

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or entry points are named. Start by locating the flows for item visibility, partner-group item permissions, deactivation, and child requests, then inspect their existing automated tests. Done means each listed action warns when affected items are used by partner child requests, allows proceeding, and has supporting tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
rails, ruby
Domain
full-stack
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.