rubyforgood / rubyforgood/human-essentials

[Investigation] ChilditemRequest - can we get rid of it?

Open
#4,656 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

core team
Dominant language
Ruby
Stars
593
Forks
593
Avg merge
4d 22h
Merged PRs (30d)
41

Description

Summary

Check if we can get rid of ChildItemRequest.

Details

A cursory inspection of ChildItemRequest indicated that maybe it is there to support outdated functionality from before the databases were combined.
Check thoroughly to determine whether we can, indeed, get rid of it. Are there any implications to old production data, etc.

It is possible that it is still important as a join table between the children and the requests.

This is core team because it probably requires looking at production data.

Criteria for completion

  • check back with the Sunday planning meeting -- can we get rid of it?

Bonus round

  • if we can, a PR to remove it.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are named. Start by tracing all references to ChildItemRequest and reviewing how it relates to children, requests, combined databases, and old production data; consult the Sunday planning meeting. Done means deciding whether it can be removed, with a removal PR only if that decision is affirmative.

Written by the indexing model from the issue text.

Assessment

Tech stack
rails, ruby
Domain
backend, database
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.