rubyforgood / rubyforgood/human-essentials
Include inactive items in distribution reports
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 593
- Forks
- 593
- Avg merge
- 4d 22h
- Merged PRs (30d)
- 41
Description
Summary
Include inactive items in reports of items that have been distributed
Why
Accuracy -- any now-inactive items that were distributed were, indeed, distributed!
Details
Currently, inactive items are included in the distribution totals in the distribution index, but not in the distributions reports (under Reports, when you are logged in as org_admin1@example.com). These reports include Distribution by County and Itemized distributions
Criteria for completion
- Inactive items included in Distribution by County report
- Inactive items included in Itemized Distributions report
- Test to demonstrate this is so
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the entry points for the Distribution by County and Itemized Distributions reports, then compare their inactive-item handling with the distribution index. Add a test covering inactive distributed items and verify both reports include them. Done means both completion criteria pass and the test demonstrates the behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rails, ruby
- Domain
- analytics
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100