rubyforgood / rubyforgood/human-essentials

Clean up unused base item fields

Open
#3,993 8 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

BLOCKED core team stale
Dominant language
Ruby
Stars
593
Forks
593
Avg merge
4d 22h
Merged PRs (30d)
41

Description

Summary

Some of the fields on base item are not used. Delete them.

Why

Avoiding future developer confusion

Details

Look at the super user base item form and the BaseItem model. They don't match. Check the fields that are not represented -- if they are not used in the system at all, then they should be deleted.

Criteria for completion

[] migration to delete the fields
[] all tests pass after migration

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Compare the super user base item form with the BaseItem model, then search the system for fields present in the model but not represented in the form. Confirm unused fields before creating the deletion migration, and run the full test suite to verify that all tests pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
rails, ruby
Domain
backend, database
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.