Improve test coverage in low-coverage controllers, notifications, and JavaScript

Summary

An audit of test coverage identified several areas with significantly lower coverage than the project average (~91% Ruby line coverage). Every Ruby app file has a corresponding spec file, so the gaps are about depth of coverage, not missing files entirely.

Ruby Coverage Gaps

Controllers (target: match project average of 91%+)

Notifications

Policies

JavaScript Coverage Gaps (46.75% overall)

There are also 2 failing Jest tests in validated_form.test.js (color format mismatch: rgb() vs hex).

Suggested approach

• Controllers: Add request specs or system tests covering untested actions (per ADR 0006, system tests are preferred)
• Notifications/Policies: Add unit specs for uncovered branches
• JavaScript: Add Jest tests for the 4 files under 25% coverage as the highest-value targets
• Jest failures: Fix the 2 failing assertions in validated_form.test.js

How to reproduce

# Ruby coverage report
RUN_SIMPLECOV=true bundle exec rspec
open coverage/index.html

# JavaScript coverage
npx jest --coverage

# Check for missing spec files
bundle exec rake test_checker

Notes

• lib/tasks directory is at 49.7% but most of those are one-time deployment rake tasks — lower priority
• Coverage data is from the last SimpleCov run; re-run to get current numbers

Start by running the Ruby and JavaScript coverage commands in the issue, then inspect the listed controller, notification, policy, and JavaScript files alongside their existing specs. Prioritize the four JavaScript files below 25% coverage or a smaller Ruby area, following ADR 0006 for controller tests. Done means added tests cover the selected branches and the relevant test suite passes, including the validated_form.test.js failures if addressed.