rubyforgood / rubyforgood/casa

☂️ Replace stub `pending` specs with real tests

Open
#5,563 16 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

no-issue-activity
Dominant language
Ruby
Stars
381
Forks
542
Avg merge
3d 15h
Merged PRs (30d)
47

Description

What type(s) of user does this feature affect?
Steve Ballmer DEVELOPERS DEVELOPERS DEVELOPERS

Status (updated 2026-05-02): the original framing of this umbrella is stale. .allow_skipping_tests is now empty — that gate is satisfied. But it was emptied in #6517 (Oct 2025) by stubbing 52 spec files with pending "add some tests for X" placeholders rather than by writing real tests. The umbrella's actual goal — real tests for those files — is not done.

41 stub specs still remain. Find them with:

grep -rl 'pending "add some tests for' spec/

Definition of done for one stub:

  • Delete the pending "add some tests for X" line.
  • Add at least one real it / describe block that exercises a behavior of the class/module under test.
  • Make sure the spec actually runs — no pending, skip, or xit left in the file.
  • One stub file per PR is fine; bundle several if they're tiny or share a theme.

Reference: the placeholder pattern was introduced in #6517. Anything matching the grep above is fair game.


QA Login Details:
Link to QA site

Login Emails:

  • volunteer1@example.com view site as a volunteer
  • supervisor1@example.com view site as a supervisor
  • casa_admin1@example.com view site as an admin

password for all users: 12345678

Questions? Join Slack!

We highly recommend that you join us in slack https://rubyforgood.herokuapp.com/ #casa channel to ask questions quickly and hear about office hours (currently Wednesday 6-8pm Pacific), stakeholder news, and upcoming new issues.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Run grep -rl 'pending "add some tests for' spec/ and choose one matching spec file. Read the class or module under test and nearby specs to identify a behavior to exercise, then run that file directly. Done means the placeholder is removed, at least one real it or describe block runs, and no pending, skipped, or xit examples remain.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
testing-qa
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.