rubyforgood / rubyforgood/awbw
Retire /people/:id/all_comments now that the combined feed replaces it
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 15
- Forks
- 26
- Avg merge
- 12h 42m
- Merged PRs (30d)
- 242
Description
🤖 From Claude: Filed as a follow-up to #2355.
What
/people/:id/all_comments is no longer linked from anywhere. #2355 added /people/:id/comments_and_communications — a superset that shows the same aggregated comments interleaved with the person's communications — and repointed every caller at it:
- the combined comments & communications section on the person, event registration, scholarship, story, and story idea forms
topic_subscriptions/_form.html.erbcontinuing_education_registrations/edit.html.erbusers/_form.html.erb
The old page is still reachable by typing the URL, but nothing navigates there.
Why it wasn't done in #2355
The instruction was to repoint the links, not to delete the page — and the two pages aren't quite identical, so retiring it is a judgement call worth making deliberately:
- The new page covers it. Both use
PersonCommentAggregator, both have a composer with the same record picker, and the new one adds communications, more filters, and full-height bodies. - What differs.
all_commentsedits a comment inline (comments/_aggregated_comment+comments/create.turbo_stream.erbprepending into the feed). The combined page is read-only per row — you click through to the record to edit. If inline editing matters, port it before deleting.
Scope if we retire it
config/routes.rb— theget :all_commentsmember routePeopleController#all_commentsand its entry in theset_personbefore_actionapp/views/people/all_comments.html.erb,app/views/people/person_comments_results.html.erbspec/requests/people_all_comments_spec.rb- the "Aggregated comments for a person" entry in
config/features.yml(or repoint itsaction_pathat the new page) - check whether
comments/_feedandcomments/_aggregated_commentstill have callers — the global/commentsindex uses them, so they stay
Alternative
Keep it addressable and leave it unlinked. Cheap, but it becomes a second person-comments page that drifts.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with config/routes.rb, PeopleController, and the listed all_comments views, then read spec/requests/people_all_comments_spec.rb and the feature entry in config/features.yml. Confirm whether inline editing must be preserved, then verify the obsolete route and callers are retired or repointed without removing shared comments partials still used by /comments.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rails, ruby
- Domain
- backend, testing
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Clearly specified
- Newbie friendliness
- 68/100