rubyforgood / rubyforgood/awbw

Remove superseded legacy monthly-report submission views

Open
#2,334 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Ruby
Stars
15
Forks
26
Avg merge
12h 42m
Merged PRs (30d)
242

Description

The monthly-report submission flow was reimplemented in ReportsController (reports#new/create/editapp/views/reports/*). The old app/views/monthly_reports/* submission views were left behind, unrouted.

#2333 removes the orphaned monthly_reports/new.html.erb (its only unique purpose was the now-deleted liaison gate), which leaves its _form partial — and likely several sibling partials — with no renderer.

Task

Audit app/views/monthly_reports/ and remove the submission-flow views that no controller/action renders, verifying each is unrendered before deleting (grep for render, routes, and partial references — not just the filename). The live MonthlyReportsController only serves index / monthly_reports_results / show, so those and their partials stay.

Likely-orphaned candidates to confirm (superseded by app/views/reports/):

  • _form.html.erb (orphaned once #2333 lands)
  • monthly_select_type.html.erb
  • _media_file.html.erb
  • _report_form_field_answers.html.erb
  • _sectorable_items.html.erb
  • _quotable_item_quote_fields.html.erb
  • _quote.html.erb

Notes

  • Follow-up to #2333 (dead liaison gate) and #2321 / #432 (position cleanup).
  • Confirm each partial isn't shared by a live reports/* or monthly_reports/{index,show} view before removing.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Audit app/views/monthly_reports/ alongside the live MonthlyReportsController actions and the replacement app/views/reports/ views. Grep routes, render calls, and partial references for each listed candidate, including _form and its siblings. Done means removing only views confirmed unrendered while retaining index, monthly_reports_results, show, and their shared partials.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
frontend
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
72/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.