rubyforgood / rubyforgood/awbw
EventProgramStatusReport: wire up or drop the unused featured_year/prior_year API
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 15
- Forks
- 26
- Avg merge
- 12h 42m
- Merged PRs (30d)
- 242
Description
🤖 From Claude:
Found while reviewing the org affiliation / program-status branch (maebeale/remove-org-status-columns).
EventProgramStatusReport mirrors its sibling reports' period API, but nothing reads it:
#featured_year,#prior_year,#all_trainings_group,#years_by_valuehave no callers.EventsController#program_statusespassesfeatured_year: selected_year, which therefore goes nowhere.events/program_statuses.html.erband_program_status_report.html.erbreadyearsplus theAggregatessums; the hub card usesperiod_scope.
Two ways out:
- Wire it up — add a KPI strip to
program_statuses.html.erbthe wayparticipation.html.erbandrevenue.html.erbusefeatured_year/prior_yearfor year-over-year deltas. Probably the intent, and it's the figure annual reporting wants. - Drop it — delete the four methods and the
featured_year:constructor argument, keepingperiod_scope(which the reports hub does use).
Not urgent; no user-visible effect either way.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with EventProgramStatusReport and trace the featured_year argument from EventsController#program_statuses into events/program_statuses.html.erb and _program_status_report.html.erb. Compare the usage in participation.html.erb and revenue.html.erb before choosing whether to add the KPI strip or remove the unused API. Done means the selected direction is implemented consistently and no unused interface remains.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ruby
- Domain
- full-stack
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 42/100