rubyforgood / rubyforgood/awbw

EventProgramStatusReport: wire up or drop the unused featured_year/prior_year API

Open
#2,255 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Ruby
Stars
15
Forks
26
Avg merge
12h 42m
Merged PRs (30d)
242

Description

🤖 From Claude:

Found while reviewing the org affiliation / program-status branch (maebeale/remove-org-status-columns).

EventProgramStatusReport mirrors its sibling reports' period API, but nothing reads it:

  • #featured_year, #prior_year, #all_trainings_group, #years_by_value have no callers.
  • EventsController#program_statuses passes featured_year: selected_year, which therefore goes nowhere.
  • events/program_statuses.html.erb and _program_status_report.html.erb read years plus the Aggregates sums; the hub card uses period_scope.

Two ways out:

  • Wire it up — add a KPI strip to program_statuses.html.erb the way participation.html.erb and revenue.html.erb use featured_year / prior_year for year-over-year deltas. Probably the intent, and it's the figure annual reporting wants.
  • Drop it — delete the four methods and the featured_year: constructor argument, keeping period_scope (which the reports hub does use).

Not urgent; no user-visible effect either way.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with EventProgramStatusReport and trace the featured_year argument from EventsController#program_statuses into events/program_statuses.html.erb and _program_status_report.html.erb. Compare the usage in participation.html.erb and revenue.html.erb before choosing whether to add the KPI strip or remove the unused API. Done means the selected direction is implemented consistently and no unused interface remains.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
full-stack
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.