rubyforgood / rubyforgood/alongwithyou
Request timeout doesn't cover the body read
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 9
- Forks
- 4
- Avg merge
- 9h 34m
- Merged PRs (30d)
- 16
Description
mobile/src/lib/api.ts:108 clears the timer in finally as soon as fetch resolves, i.e. when headers arrive. A server that sends headers then stalls the body leaves response.text() hanging forever, the exact failure mode the timeout was meant to close, just moved one step later. Clear the timer after the body read instead.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at mobile/src/lib/api.ts:108 and trace the timer cleanup around fetch and response.text(). Keep the timeout active through the body read, then clear it afterward. Done means a response that stalls after headers is still terminated by the request timeout rather than leaving response.text() hanging.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- api, mobile
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 82/100