rubyforgood / rubyforgood/Flaredown
Entering zip code often gets wrong country
Open
Nobody has claimed this yet.
type:bug
- Dominant language
- Ruby
- Stars
- 50
- Forks
- 21
- Avg merge
- 6d 12h
- Merged PRs (30d)
- 16
Description
I have noticed this in staging: when I enter a zip code for 19013, I get a city in Italy, and when I enter zip code 10001 it comes back as Vilnius, Latvia. Consider:
- The user has already told us their country via profile in many cases, so use that when available
- This behavior may change when we fix #535
- When in doubt, is there a default we should use? United States?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files, tests, or entry points are named. Begin by locating the zip-code lookup used in staging and reproduce the cases for 19013 and 10001. Done means country information from the user profile is considered when available and an agreed fallback is covered by tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rails, ruby
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100