Suggestion: Disable ENABLE_MARSHALLING by default
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 41
- Forks
- 25
- PR merge metrics
- No merged PRs in 30d
Description
Given the plethora of cases about possible RCE vulnerabilities that have led to the 0.3.3 release, I would like to argue that the default object marshalling is incorrect.
Beside the security related issues, there is also the issue that XML-RPC is a language agnostic protocol, and the Ruby object marshalling is a Ruby only extension. It would not make any sense to serialize a Ruby object when the server is running Perl, Python or any other language that is not Ruby. The other XML-RPC extensions (8 byte integers, nil serialization, nil deserialization) are disabled by default as well.
Of course, I might be totally wrong here. Are there any people who actually use the object serialization of this gem?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating ENABLE_MARSHALLING and comparing its default handling with the other XML-RPC extensions mentioned in the issue. Review whether existing users depend on Ruby object serialization and determine what tests or documentation would define the default change as complete.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ruby
- Domain
- api
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100