Don't enable test mode by TERM=dumb
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 311
- Forks
- 99
- Avg merge
- 6d 4h
- Merged PRs (30d)
- 1
Description
Problem
In IRB's test code, TERM=dumb triggers Reline's test mode io Reline::GeneralIO (unlike the name, this is not a general io)
In practice, TERM=dumb seems to be used in real world. (example: https://github.com/pry/pry/issues/2303)
It will unintentionally enables Reline's test mode and cause problems.
I think Reline should not use TERM=dumb to enable test mode. We need another way to enable it, or remove this test mode after fixing IRB's test not to depend on this.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting IRB's test code and the path where TERM=dumb selects Reline::GeneralIO. Compare that behavior with the real-world TERM=dumb case described in the issue, then determine a replacement test-mode mechanism or remove the mode after IRB tests no longer depend on it; done means TERM=dumb no longer unintentionally enables test mode.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ruby
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100