Completion dialog is not updated when searching with ed_search_*_history
Open
Nobody has claimed this yet.
bug
- Dominant language
- Ruby
- Stars
- 311
- Forks
- 99
- Avg merge
- 6d 4h
- Merged PRs (30d)
- 1
Description
Steps to reproduce
- Type
aa=0 - Enter
- Type
a - Type
PgUp - You can search from history, but the completion dialog is not updated.
Expected behavior
As with the normal up/down keys, the completion dialog is updated.
irb_info
I used Reline HEAD (https://github.com/ruby/reline/commit/3aeea2ad4e7c06d4ccb36548a18ef091b12cd4e1) and IRB HEAD (https://github.com/ruby/irb/commit/52b79806ea6d46e4b43b24277d00add204ae127a).
irb(main):003:0> irb_info
=>
Ruby version: 3.3.0
IRB version: irb 1.6.3 (2023-03-06)
InputMethod: RelineInputMethod with Reline 0.3.2
.irbrc path: /Users/mi/.irbrc
RUBY_PLATFORM: x86_64-darwin21
East Asian Ambiguous Width: 1
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the sequence in Reline: enter aa=0, press Enter, type a, then PgUp to search history through ed_search_*_history. Compare the completion dialog with the normal up/down-key behavior. Done means the dialog updates during history searches in the same way as it does for normal navigation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ruby
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100