Reline ignores echoing suppression
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 311
- Forks
- 99
- Avg merge
- 6d 4h
- Merged PRs (30d)
- 1
Description
If terminal echoing suppressed, reline seems sending echo anyway. Is it possible to avoid that?
E.g. with ENABLE_ECHO_INPUT 0x0004 unsetting. https://docs.microsoft.com/en-us/windows/console/setconsolemode
Readline honors this setting and does not sent echo.
I believe this happens somewhere here https://github.com/ruby/reline/blob/master/lib/reline/line_editor.rb#L530
(If i comment this out, everything works as expected, without echo)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at lib/reline/line_editor.rb around line 530 and review how input is echoed on Windows. Check the ENABLE_ECHO_INPUT behavior described in SetConsoleMode and compare it with readline. Done means reline no longer sends echo when terminal echoing is disabled.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ruby
- Domain
- cli, operating-systems
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100