ruby / ruby/rbs

bin/sort sorts private as though it were a method

Open
#223 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Ruby
Stars
2.2k
Forks
256
Avg merge
6d 17h
Merged PRs (30d)
37

Description

private and protected shouldn't be sorted by bin/sort.

Input:

module Foo
  def baz: (*untyped) -> untyped

  private

  def foo: (*untyped) -> untyped

  def bar: (*untyped) -> untyped
end

Output:

module Foo
  private

  def bar: (*untyped) -> untyped

  def baz: (*untyped) -> untyped

  def foo: (*untyped) -> untyped
end

What I'd expect the output to look like, with the private methods sorted within themselves:

module Foo
  def baz: (*untyped) -> untyped

  private

  def bar: (*untyped) -> untyped

  def foo: (*untyped) -> untyped
end

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading and running bin/sort with the RBS input shown in the issue. Check how visibility declarations are classified during sorting, then verify that public methods remain separate and methods under private or protected visibility are sorted within their own section.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
cli
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.