ruby / ruby/rbs

No error when a function definition contains non-balanced braces

Open
#1,221 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Ruby
Stars
2.2k
Forks
256
Avg merge
6d 17h
Merged PRs (30d)
37

Description

Sorry if I'm wrong in my understanding of the specs or where to report it.

The following code does not generate a parse error
No error occurs on steep also.

RBS::Parser.parse_method_type("(foo: Integer]) -> Integer")

My repository for testing https://github.com/Bugfire/rbs-test/pull/1/checks

Thanks for the great Steep/RBS.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue with RBS::Parser.parse_method_type("(foo: Integer]) -> Integer") and inspect the parser path for method types and delimiter validation. Done means the non-balanced braces are rejected with a parse error, with the behavior covered by a regression test if the existing parser tests provide a suitable location.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
compilers
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.