Implementation specific build_exception
Open
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 597
- Forks
- 223
- Avg merge
- 11h 23m
- Merged PRs (30d)
- 3
Description
The current build_exception relies on the Exception implementation containing a instance variable mesg:
https://github.com/ruby/ruby/blob/c8661de0143c1d434dd9f68910ae304c59f8576b/ext/psych/psych_to_ruby.c#L9-L16
Should this use rb_exc_new_str() (which would also call initialize)?
cc: @eregon
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in ext/psych/psych_to_ruby.c at the build_exception implementation linked in the issue, then review the rb_exc_new_str API and its initialization behavior. Determine whether replacing the mesg instance-variable dependency addresses the implementation-specific concern, and verify the resulting exception construction with the relevant Psych tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c, ruby
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100