ruby / ruby/psych

Change `symbolize_names` to `symbolize_keys`

Open
#341 9 comments 12 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Ruby
Stars
597
Forks
223
Avg merge
11h 23m
Merged PRs (30d)
3

Description

This occured to me while testing this option without the docs in front of me; it didn't work because I thought the option was named symbolize_keys (and only one day before I wrote the docs for it...). Why symbolize_names? symbolize_keys describes exactly what it does, symbolizing Hash keys, not names. Also, symbolize_keys already has some spread as a method name.

I will provide a PR if there is agreement on this.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by searching the repository for symbolize_names, including its documentation and tests, then inspect how the option is parsed and exposed. Check whether symbolize_keys is already used elsewhere and define the compatibility scope; done means the agreed name is handled consistently and the relevant tests and docs pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
tooling
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.