ruby / ruby/ostruct

Truffleruby test failure in test_performance_warning(TC_OpenStruct)

Open
#65 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Ruby
Stars
175
Forks
35
Avg merge
16h 14m
Merged PRs (30d)
1

Description

There is a current test failure on TruffleRuby, in the test test_performance_warning(TC_OpenStruct).

===============================================================================
Failure: test_performance_warning(TC_OpenStruct):
  pid 1875 exit 0
  | /home/runner/.rubies/truffleruby-24.1.1/lib/mri/rubygems.rb:1207: warning: unstable interpolated regexps cause deoptimization loops which hurt performance significantly, avoid creating regexps dynamically where possible or cache them to fix this
  | -e:1: warning: OpenStruct use is discouraged for performance reasons
  .
  
  1. [2/3] Assertion for "stderr"
     | <["-e:1: warning: OpenStruct use is discouraged for performance reasons"]> expected but was
     | <["/home/runner/.rubies/truffleruby-24.1.1/lib/mri/rubygems.rb:1207: warning: unstable interpolated regexps cause deoptimization loops which hurt performance significantly, avoid creating regexps dynamically where possible or cache them to fix this",
     |  "-e:1: warning: OpenStruct use is discouraged for performance reasons"]>.
     | 
     | diff:
     | + ["/home/runner/.rubies/truffleruby-24.1.1/lib/mri/rubygems.rb:1207: warning: unstable interpolated regexps cause deoptimization loops which hurt performance significantly, avoid creating regexps dynamically where possible or cache them to fix this",
     | - ["-e:1: warning: OpenStruct use is discouraged for performance reasons"]
     | ? ^
     | +  "-e:1: warning: OpenStruct use is discouraged for performance reasons"]
     | ? ^
     | 
     | folded diff:
     | + ["/home/runner/.rubies/truffleruby-24.1.1/lib/mri/rubygems.rb:1207: warning: u
     | + nstable interpolated regexps cause deoptimization loops which hurt performance
     | +  significantly, avoid creating regexps dynamically where possible or cache the
     | + m to fix this",
     | - ["-e:1: warning: OpenStruct use is discouraged for performance reasons"]
     | ? ^
     | +  "-e:1: warning: OpenStruct use is discouraged for performance reasons"]
     | ? ^.
  <false> is not true.
/home/runner/work/ostruct/ostruct/vendor/bundle/truffleruby/3.2.4.24.1.0.1/gems/test-unit-ruby-core-1.0.6/lib/core_assertions.rb:540:in `assert'
/home/runner/work/ostruct/ostruct/vendor/bundle/truffleruby/3.2.4.24.1.0.1/gems/test-unit-ruby-core-1.0.6/lib/core_assertions.rb:774:in `assert_all_assertions'
/home/runner/work/ostruct/ostruct/vendor/bundle/truffleruby/3.2.4.24.1.0.1/gems/test-unit-ruby-core-1.0.6/lib/core_assertions.rb:110:in `assert_in_out_err'
/home/runner/work/ostruct/ostruct/test/ostruct/test_ostruct.rb:425:in `test_performance_warning'

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with test/ostruct/test_ostruct.rb at test_performance_warning(TC_OpenStruct), then reproduce the failure on TruffleRuby and inspect the stderr assertion. Done means the test no longer fails because of the unexpected rubygems.rb warning while still checking the OpenStruct performance warning.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.