ruby / ruby/open-uri

Expose ignore_eof option for Net::HTTP

Open
#26 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Ruby
Stars
61
Forks
22
Avg merge
15m
Merged PRs (30d)
2

Description

The other day I discovered an ignore_eof setting that was added to Net::HTTP and Net::HTTPResponse in https://github.com/ruby/net-http/pull/15

Was wondering it makes sense for open-uri to expose setting ignore_eof via options or even setting it to false by default, but that's probably not backwards compatible, so it leaves us only the first solution?

wdyt?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading how open-uri wraps Net::HTTP and Net::HTTPResponse, then compare the existing ignore_eof support described in ruby/net-http#15. Expose ignore_eof through open-uri options without changing the default behavior, and verify that callers can pass the setting through successfully.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
networking
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.