ruby / ruby/gem_rbs_collection

Concurrent appears to be causing issues.

Open
#552 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Ruby
Stars
303
Forks
136
Avg merge
5h 15m
Merged PRs (30d)
6

Description

I have included a bunch of gems from this repo in my collection. Specifically, I need Concurrent::Map from the concurrent-ruby gem.

However, when including this gem steep reports an error for both signatures in this file.

https://github.com/ruby/gem_rbs_collection/blob/7a105f52053ce1c708b605dfa9c1ab8473424036/gems/concurrent-ruby/1.1/utility/processor_counter.rbs#L2

Non-overloading method definition of `physical_processor_count` in ``::Concurrent`` cannot be duplicated
  Diagnostic ID: RBS::DuplicateMethodDefinition

When I comment out the two method signatures in that line, everything is fine.

Is there a better workaround?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Open gems/concurrent-ruby/1.1/utility/processor_counter.rbs at line 2 and inspect the two signatures reported by Steep. Reproduce the DuplicateMethodDefinition diagnostic with a use of Concurrent::Map, then verify the completed change removes the duplicate error without requiring those signatures to be commented out.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
tooling
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.