`Fiddle::Pointer#to_value` is unsafe
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 195
- Forks
- 53
- Avg merge
- 23h 57m
- Merged PRs (30d)
- 1
Description
Well, it's pretty self-explanatory. It returns (VALUE)(data->ptr), and ptr is obviously not marked, so can be GCed. This method is either should be removed completely (it'll still e possible to hack around with Fiddle.dlunwrap, but this at least feels hacky) or to be allowed only for pointers marked to be in fact VALUEs (mark return value type in Function constructor), and they of course should gc_mark their ptrs. Btw, there is no way to create a pointer from Ruby object, either.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the implementation of Fiddle::Pointer#to_value and the Function constructor, then inspect how pointer marking and Fiddle.dlunwrap interact with Ruby's garbage collector. The issue presents removal and type-restriction alternatives; done requires a decided safety design, implementation, and coverage for the affected behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ruby
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100