after_fork_parent method waits for all child processes to stop
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 45/100
Research direction
Start at lib/debug/local.rb lines 106-107 and inspect after_fork_parent, then reproduce the behavior with the Gemfile and test_daemon.rb example using daemons. Confirm the forked worker behavior from the issue's ps output; done means child processes other than debug no longer remain blocked waiting to stop.
Written by the indexing model from the issue text.
Description
Your environment
ruby -v: ruby 3.2.2 (2023-03-30 revision e51014f9c0) [x86_64-linux]rdbg -v: rdbg 1.9.2
Describe the bug
I'm using delayed_job.
When I tried to increase the number of workers, the number of workers did not increase because the child process did not stop.
The problem was due to Process.waitpid below.
https://github.com/ruby/debug/blob/master/lib/debug/local.rb#L106-L107
To Reproduce
delayed_job uses daemons.
Script:
Gemfile
# frozen_string_literal: true
source "https://rubygems.org"
gem "debug", platforms: %i[ mri windows ]
gem "daemons"
test_daemon.rb
#!/usr/bin/env ruby
require 'bundler/setup'
Bundler.setup
require 'debug'
require 'daemons'
2.times do |i|
Daemons.run_proc("test_daemon.#{i}") do
loop do
end
end
end
Terminal:
$ test_daemon.rb start
Child processes do not stop and workers do not increase.
$ ps aux
--snip--
sada 14719 1.8 0.2 177232 37168 pts/6 Sl+ 17:01 0:00 ruby ./test_daemon.rb start
sada 14735 0.0 0.2 177232 33832 ? Ssl 17:01 0:00 ruby ./test_daemon.rb start
sada 14737 94.6 0.2 180308 37540 ? Rl 17:01 0:08 test_daemon.0
The following fork operations are no longer possible.
- Forks another child process and exits first child. This prevents the potential of acquiring a controlling terminal.
Also, in Rails development, debug is loaded by default, When starting delayed_job, unexpected block is caused by this issue.
Expected behavior
Child processes other than debug do not wait to stop.
- Dominant language
- Ruby
- Stars
- 1.3k
- Forks
- 146
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ruby/debug
-
Difficulty 3/5 1-2 days Newbie friendliness 68/100
-
Support exceptionOptions in setExceptionBreakpoints to catch arbitrary exception classes via DAP Open
Difficulty 4/5 3-5 days Newbie friendliness 55/100
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
-
Difficulty 4/5 3-5 days Newbie friendliness 52/100
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
バグ
Difficulty 1/5 Under an hour Newbie friendliness 92/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
voxpupuli/puppet-epel#186 · 1 comment ·
-
external_created_at is no longer used for the message timestamp since the new message UI (v4.4.0) OpenBug Frontend
Difficulty 2/5 1-3 hours Newbie friendliness 78/100