test_cgi_cookie_new_with_domain does not run in 2.6 or earlier
Open
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 55
- Forks
- 33
- Avg merge
- 7d 3h
- Merged PRs (30d)
- 1
Description
The test added in 107a0c67f922044dc78e2fde94f991206267a6a0 contains a test that uses `*h to merge two string hashes. This does not work under Ruby 2.6 and earlier, making it impossible to test v0.1.0.2 on any Ruby 2.6-compatible implementation.
Error: test_cgi_cookie_new_with_domain(CGICookieTest): TypeError: hash key "name" is not a Symbol
/home/enebo/work/gems/cgi/test/cgi/test_cgi_cookie.rb:65:in `test_cgi_cookie_new_with_domain'
62:
63: def test_cgi_cookie_new_with_domain
64: h = {'name'=>'name1', 'value'=>'value1'}
=> 65: cookie = CGI::Cookie.new('domain'=>'a.example.com', **h)
66: assert_equal('a.example.com', cookie.domain)
67:
68: cookie = CGI::Cookie.new('domain'=>'1.example.com', **h)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in test/cgi/test_cgi_cookie.rb at test_cgi_cookie_new_with_domain and review the call shown in the failure under Ruby 2.6 and earlier. Run this test with a Ruby 2.6-compatible implementation and verify that it executes and passes for both example domains.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ruby
- Domain
- testing
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100