ruby-ui / ruby-ui/ruby_ui

`CommandInput` sets `aria-expanded` to a boolean

Open
#543 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Ruby
Stars
1k
Forks
67
Avg merge
3d 12h
Merged PRs (30d)
14

Description

  • Where: command_input.rb, aria_expanded: true. Snapshot
    command/dialog line 18.
  • Effect: same root cause as item 2; listed separately because the fix
    is a real state string ("false" at rest, toggled by the controller),
    not just "true".
  • Fix: aria_expanded: "false" and have command_controller.js set it;
    re-record (on the 2.0 line) command/*.

Surfaced by the golden HTML suite (PR #536), which pins what 1.6 renders today — this defect included. Per maintainer decision (2026-09-19) main stays as is: this is addressed on the 2.0 line, and the golden snapshot that pins it is re-recorded there with the diff reviewed.

Source: design/v2/follow-up-issues.md.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in command_input.rb at aria_expanded and inspect command_controller.js for the state update. Run the golden HTML suite or the command/* snapshot, then re-record it on the 2.0 line and review the diff. Done means the resting state and controller-managed state use the expected ARIA strings without changing the 1.6 line.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, ruby
Domain
accessibility, frontend, testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
72/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.