ruby-ui / ruby-ui/ruby_ui

`Input` defaults to `type="string"`

Open
#541 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Ruby
Stars
1k
Forks
67
Avg merge
3d 12h
Merged PRs (30d)
14

Description

  • Where: Input's default type: in input.rb, and date_picker.rb's
    input_attrs (type: "string"). Snapshot date_picker/without_label.
  • Effect: string is not an HTML input type; browsers fall back to
    text, so nothing breaks, but the attribute is invalid and will be
    flagged by any validator, including Herb's.
  • Fix: type: "text" in both places; re-record (on the 2.0 line) input/*,
    date_picker/* and whatever else changes.

Surfaced by the golden HTML suite (PR #536), which pins what 1.6 renders today — this defect included. Per maintainer decision (2026-09-19) main stays as is: this is addressed on the 2.0 line, and the golden snapshot that pins it is re-recorded there with the diff reviewed.

Source: design/v2/follow-up-issues.md.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the default type in input.rb and input_attrs in date_picker.rb, then inspect the date_picker/without_label snapshot. Work on the 2.0 line, re-record input/, date_picker/, and any other affected golden snapshots, and review the diff to confirm the rendered type is text rather than string.

Written by the indexing model from the issue text.

Assessment

Tech stack
html, ruby
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
82/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.