ruby-grape / ruby-grape/grape

error_response deprecation ?

Open
#2,253 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

chore
Dominant language
Ruby
Stars
10k
Forks
1.2k
Avg merge
14h 38m
Merged PRs (30d)
92

Description

There's a todo for deprecation (it's been a while) but there's no warn DEPRECATION. Since it's use internally, adding a warning will pop every single time.

I think we should not use it internally and add a proper warning DEPRECATION. What do you think ?

https://github.com/ruby-grape/grape/blob/0fa5216947816fff9d3cb37bab44144ee7d33701/lib/grape/middleware/error.rb#L62-L71

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with lib/grape/middleware/error.rb around lines 62-71 and read the linked UPGRADING.md guidance for replacing error_response with error in rescue_from blocks. Trace the internal use of error_response and determine the intended deprecation-warning scope; done means internal use no longer triggers the deprecated path and the public deprecation behavior is documented.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
api, backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.