ruby-grape / ruby-grape/grape

Validation with values range doesn't work without specifying a type.

Open
#1,516 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feature request
Dominant language
Ruby
Stars
10k
Forks
1.2k
Avg merge
14h 38m
Merged PRs (30d)
92

Description

I'm merely trying to specify a param to have a valid range between 1 and a million like so :

optional :difference_threshold, values: { value: 1..1000000, message: 'Value not in range, from 1 to 1000000' }, default: 1

when calling the endpoint with a valid integer in that range I see this error:

 ERROR: ["data[difference_threshold] Value not in range, from 1 to 1000000"]

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the optional parameter declaration shown in the issue with an integer inside the 1..1000000 range, then trace Grape's values validation and type handling for that parameter. Done means valid integers in the range are accepted while values outside it are rejected with the configured message.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
api
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.